[webkit-reviews] review granted: [Bug 202170] [EWS] JSC queues should dynamically add required build steps for re-testing the patch : [Attachment 379493] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 202170: [EWS] JSC queues should dynamically add required build steps for
re-testing the patch
https://bugs.webkit.org/show_bug.cgi?id=202170

Attachment 379493: Patch

https://bugs.webkit.org/attachment.cgi?id=379493&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 379493
  --> https://bugs.webkit.org/attachment.cgi?id=379493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379493&action=review

>>> Tools/BuildSlaveSupport/ews-build/steps.py:839
>>> +	     rc = shell.Test.evaluateCommand(self, cmd)
>> 
>> Any reason we aren't using super(...) here?
> 
> To avoid the style warning:	"ERROR:
Tools/BuildSlaveSupport/ews-build/steps.py:838: 
[RunJavaScriptCoreTests.evaluateCommand] Use of super on an old style class 
[pylint/E1002] [5]"

Ah, shell.Test is an old style class.