[webkit-reviews] review denied: [Bug 202031] Web Inspector: Canvas: modifications to shader modules can be shared between vertex/fragment shaders : [Attachment 379219] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 202031: Web Inspector: Canvas: modifications to shader modules can be
shared between vertex/fragment shaders
https://bugs.webkit.org/show_bug.cgi?id=202031

Attachment 379219: Patch

https://bugs.webkit.org/attachment.cgi?id=379219&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 379219
  --> https://bugs.webkit.org/attachment.cgi?id=379219
Patch

After speaking with Saam, he suggested that if the vertex and fragment shaders
both shared the same shader module, we shouldn't use a split content view and
instead update both the vertex and fragment shaders at the same time.  I think
this is a great idea, as it handles the case where there are utility functions
that are shared between the vertex and fragment shaders, so that any edits are
shared.