[webkit-reviews] review granted: [Bug 199163] toExponential, toFixed, and toPrecision should allow arguments up to 100 : [Attachment 379502] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 199163: toExponential, toFixed, and toPrecision should allow arguments up
to 100
https://bugs.webkit.org/show_bug.cgi?id=199163

Attachment 379502: Patch

https://bugs.webkit.org/attachment.cgi?id=379502&action=review




--- Comment #9 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 379502
  --> https://bugs.webkit.org/attachment.cgi?id=379502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379502&action=review

LGTM pending EWS.

> Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:163
> -    EXPECT_STREQ("1000000000000000000000.000000",
testStringNumberFixedWidth(1e21));
> -    EXPECT_STREQ("1000000000000000019884624838656.000000",
testStringNumberFixedWidth(1e30));
> +    EXPECT_STREQ("", testStringNumberFixedWidth(1e21));
> +    EXPECT_STREQ("", testStringNumberFixedWidth(1e30));

I suppose the e30 cases could just be removed.