[webkit-reviews] review granted: [Bug 202167] [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com : [Attachment 379500] Fix macOS builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 24 15:29:01 PDT 2019


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 202167: [iPadOS] [DataActivation] Focus moves away after focusing input
fields on www.att.com
https://bugs.webkit.org/show_bug.cgi?id=202167

Attachment 379500: Fix macOS builds

https://bugs.webkit.org/attachment.cgi?id=379500&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 379500
  --> https://bugs.webkit.org/attachment.cgi?id=379500
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=379500&action=review

> Source/WebKit/ChangeLog:48
> +	   DataActivation. However, this also fixes various cases known bugs
that are otherwise fixed in Safari only, via

various cases known bugs

> Source/WTF/wtf/spi/darwin/dyldSPI.h:49
> +#define DYLD_IOS_VERSION_13_1 0x000D0100

.2

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:329
> +    static bool isDataActivation =
applicationBundleIsEqualTo("com.apple.DataActivation"_s);

I have some bizarre vague recollection that there might be second bundle ID for
some reason? Maybe not anymore.


More information about the webkit-reviews mailing list