[webkit-reviews] review granted: [Bug 202023] Web Inspector: Include LocalResourceOverrides in the Open Resource dialog : [Attachment 379269] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 202023: Web Inspector: Include LocalResourceOverrides in the Open Resource
dialog
https://bugs.webkit.org/show_bug.cgi?id=202023

Attachment 379269: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=379269&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 379269
  --> https://bugs.webkit.org/attachment.cgi?id=379269
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=379269&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:170
> +    vertical-align: 1px;
> +    font-size: 11px;

NIT: I'd swap the order of these.

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:115
> +		   treeElement.subtitle = WI.UIString("Local Override");

Should we assert that there isn't already a `subtitle` set?  IIRC,
`WI.ResourceTreeElement` normally uses the subtitle if the resource is from a
different origin than the main origin.

On a more general note, I've often wondered if "incorrect" (or unexpected)
subtitle overriding is a prevalent occurrence/issue, and if it's something we
could proactively counteract.  Just a thought.