[webkit-reviews] review requested: [Bug 202146] We should initialize WebProcessPool::m_hiddenPageThrottlingTimer before using it. : [Attachment 379455] proposed patch.

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 202146: We should initialize WebProcessPool::m_hiddenPageThrottlingTimer
before using it.
https://bugs.webkit.org/show_bug.cgi?id=202146

Attachment 379455: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=379455&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 379455
  --> https://bugs.webkit.org/attachment.cgi?id=379455
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=379455&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:232
> +    , m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) {
m_hiddenPageThrottlingTimer.startOneShot(0_s); })

The RefCounter constructor does not run the lambda it is being given so I don't
understand the problem.