[webkit-reviews] review granted: [Bug 198621] [GTK] ANGLE's eglplatform.h is build broken with -DENABLE_X11_PLATFORM=OFF : [Attachment 379129] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 198621: [GTK] ANGLE's eglplatform.h is build broken with
-DENABLE_X11_PLATFORM=OFF
https://bugs.webkit.org/show_bug.cgi?id=198621

Attachment 379129: Patch

https://bugs.webkit.org/attachment.cgi?id=379129&action=review




--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 379129
  --> https://bugs.webkit.org/attachment.cgi?id=379129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379129&action=review

>>> Source/ThirdParty/ANGLE/PlatformGTK.cmake:8
>>> +elseif (NOT ENABLE_X11_TARGET)
>> 
>> what happens when we build with both x11 and wayland targets enabled?
> 
> In that case ANGLE_USE_X11 is defined and the X11 headers are used
> by ANGLE's “eglplatform.h” header — that is the current behaviour
> already when building with support for both Wayland and X11.

Please, add a comment here explaining why x11 is not broken even if the wayland
define is set unconditionally when building with both targets enabled.