[webkit-reviews] review granted: [Bug 202131] Import navigation-timing WPT tests that don't time out : [Attachment 379430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 24 05:36:06 PDT 2019


youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202131: Import navigation-timing WPT tests that don't time out
https://bugs.webkit.org/show_bug.cgi?id=202131

Attachment 379430: Patch

https://bugs.webkit.org/attachment.cgi?id=379430&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 379430
  --> https://bugs.webkit.org/attachment.cgi?id=379430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379430&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +	   Import navigation-timing WPT tests that don't time out

It might be simpler to import all navigation-timing tests and skip the ones
that time out.
That way, next import will be much easier.
Or update import-expectations.json to never import these tests if we really
thing they are no good.

>
LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirec
t_chain_xserver_partial_opt_in-expected.txt:1
> +Blocked access to external URL
http://www.localhost:8800/common/redirect.py?location=http://www.localhost:8800
/common/redirect-opt-in.py?location=http://localhost:8800/navigation-timing/res
ources/blank_page_green.html

We probably need to update this test to use hosts[alt]

>
LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirec
t_chain_xserver_partial_opt_in.html:50
> +	       const destUrl = make_absolute_url({subdomain: "www",

Probably here we should move out of www subdomain.
Might be best done as a follow-up so that we can upstream it to WPT.

>
LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirec
t_xserver-expected.txt:1
> +Blocked access to external URL
http://www.localhost:8800/common/redirect.py?location=http://localhost:8800/nav
igation-timing/resources/blank_page_green.html

Ditto here.


More information about the webkit-reviews mailing list