[webkit-reviews] review granted: [Bug 202081] Require a WebsiteDataStore when creating or resuming downloads : [Attachment 379414] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 202081: Require a WebsiteDataStore when creating or resuming downloads
https://bugs.webkit.org/show_bug.cgi?id=202081

Attachment 379414: Patch

https://bugs.webkit.org/attachment.cgi?id=379414&action=review




--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 379414
  --> https://bugs.webkit.org/attachment.cgi?id=379414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379414&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:1330
> +    PAL::SessionID sessionID = dataStore.sessionID();

auto

> Source/WebKit/UIProcess/WebProcessPool.cpp:1362
> +    PAL::SessionID sessionID = dataStore.sessionID();

auto

> Source/WebKit/UIProcess/API/C/WKContext.cpp:175
> +	   explicit DownloadClient(const WKContextDownloadClientBase* client,
WKContextRef context)

no need for explicit anymore

> Source/WebKit/UIProcess/API/glib/WebKitDownloadClient.cpp:43
> +    void didStart(DownloadProxy& downloadProxy) override

final here and below.

> Source/WebKit/UIProcess/Downloads/DownloadProxy.h:60
> +    static Ref<DownloadProxy> create(DownloadProxyMap&, WebsiteDataStore&,
WebProcessPool&, const WebCore::ResourceRequest&);

Could take Ref<WebsiteDataStore>&&, ditto for WebProcessPool.

> Source/WebKit/UIProcess/Downloads/DownloadProxy.h:103
> +    explicit DownloadProxy(DownloadProxyMap&, WebsiteDataStore&,
WebProcessPool&, const WebCore::ResourceRequest&);

No need of explicit.