[webkit-reviews] review granted: [Bug 202100] [Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes : [Attachment 379363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 24 04:17:43 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 202100: [Nicosia] Add implementations for fixed, positioned, sticky
ScrollingTreeNodes
https://bugs.webkit.org/show_bug.cgi?id=202100

Attachment 379363: Patch

https://bugs.webkit.org/attachment.cgi?id=379363&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 379363
  --> https://bugs.webkit.org/attachment.cgi?id=379363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379363&action=review

> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:88
> +	   }();

What's the point of the lambda here?

> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.h:43
> +class ScrollingTreePositionedNode : public ScrollingTreeNode {

is this final class?


More information about the webkit-reviews mailing list