[webkit-reviews] review granted: [Bug 202132] Refactor cellSize() out of VMInspector::verifyCellSize(). : [Attachment 379436] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 23 23:52:12 PDT 2019
Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 202132: Refactor cellSize() out of VMInspector::verifyCellSize().
https://bugs.webkit.org/show_bug.cgi?id=202132
Attachment 379436: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=379436&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379436
--> https://bugs.webkit.org/attachment.cgi?id=379436
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=379436&action=review
> Source/JavaScriptCore/runtime/CellSize.h:36
> +inline size_t cellSize(VM& vm, JSCell* cell)
why not put isDynamicallySizedType in here too?
> Source/JavaScriptCore/runtime/CellSize.h:65
> + default:
ASSERT(!isDynamicallySizedType(cell))?
More information about the webkit-reviews
mailing list