[webkit-reviews] review granted: [Bug 202006] [iPadOS] The second click event is missing on double tap when dblclick handler is not present : [Attachment 379381] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 202006: [iPadOS] The second click event is missing on double tap when
dblclick handler is not present
https://bugs.webkit.org/show_bug.cgi?id=202006

Attachment 379381: Patch

https://bugs.webkit.org/attachment.cgi?id=379381&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 379381
  --> https://bugs.webkit.org/attachment.cgi?id=379381
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379381&action=review

> Source/WebKit/Shared/ios/InteractionInformationRequest.cpp:89
> -    return (other.point - point).diagonalLengthSquared() <= 4;
> +    return (other.point - point).diagonalLengthSquared() <= radius * radius;

Nit - it might be cleaner to just share code with
InteractionInformationRequest::isValidForRequest above, by moving the distance
check into InteractionInformationRequest::isValidForRequest and treating
isValidForRequest as the case where radius == 0.