[webkit-reviews] review granted: [Bug 201738] Link mediaDataLoadsAutomatically setting to AutoplayPolicy : [Attachment 379390] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 201738: Link mediaDataLoadsAutomatically setting to AutoplayPolicy
https://bugs.webkit.org/show_bug.cgi?id=201738

Attachment 379390: Patch

https://bugs.webkit.org/attachment.cgi?id=379390&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 379390
  --> https://bugs.webkit.org/attachment.cgi?id=379390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379390&action=review

> Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7
> +

Nit: extra blank line.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575
> +    TestWebKitAPI::Util::run(&receivedLoadedEvent);

Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here?