[webkit-reviews] review granted: [Bug 202105] Reduce the amount of memory needed to store Options. : [Attachment 379372] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 202105: Reduce the amount of memory needed to store Options.
https://bugs.webkit.org/show_bug.cgi?id=202105

Attachment 379372: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=379372&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 379372
  --> https://bugs.webkit.org/attachment.cgi?id=379372
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=379372&action=review

r=me

> Source/JavaScriptCore/runtime/JSCConfig.h:42
>  #if CPU(ARM64) || PLATFORM(WATCHOS)
>  constexpr size_t PageSize = 16 * KB;
> +constexpr size_t ConfigSizeToProtect = 1 * PageSize;
>  #else
>  constexpr size_t PageSize = 4 * KB;
> +constexpr size_t ConfigSizeToProtect = 1 * PageSize;
>  #endif

Add `PageSize = 64 * KB` for `CPU(PPC64) || CPU(PPC64LE) || CPU(PPC) ||
CPU(UNKNOWN)`.