[webkit-reviews] review granted: [Bug 202097] AudioTrackPrivateMediaStreamCocoa does not need to manipulate the audio unit in play/pause methods : [Attachment 379357] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 23 06:06:27 PDT 2019
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202097: AudioTrackPrivateMediaStreamCocoa does not need to manipulate the
audio unit in play/pause methods
https://bugs.webkit.org/show_bug.cgi?id=202097
Attachment 379357: Patch
https://bugs.webkit.org/attachment.cgi?id=379357&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 379357
--> https://bugs.webkit.org/attachment.cgi?id=379357
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=379357&action=review
>
Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h:89
> + bool m_isTransitioningToPausing { false };
> + bool m_isTransitioningToPlaying { false };
Couldn't we replace these with an enum? In a case where both are set
simultaneously, wouldn't we always want the last one set to always "win"?
More information about the webkit-reviews
mailing list