[webkit-reviews] review granted: [Bug 202090] clang-tidy: Fix unnecessary copy/ref churn of for loop variables in WebCore : [Attachment 379343] Patch v1

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 202090: clang-tidy: Fix unnecessary copy/ref churn of for loop variables in
WebCore
https://bugs.webkit.org/show_bug.cgi?id=202090

Attachment 379343: Patch v1

https://bugs.webkit.org/attachment.cgi?id=379343&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 379343
  --> https://bugs.webkit.org/attachment.cgi?id=379343
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=379343&action=review
This patch looks good.

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:80
> +    std::vector<rtc::scoped_refptr<webrtc::RtpTransceiverInterface>>
transceivers(m_transceivers.size());

This change doubles the size of the final vector. This constructor takes a
vector size (read: not capacity).