[webkit-reviews] review granted: [Bug 202080] Reduce use of SessionID::defaultSessionID() in WebKit : [Attachment 379322] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 21 21:35:55 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 202080: Reduce use of SessionID::defaultSessionID() in WebKit
https://bugs.webkit.org/show_bug.cgi?id=202080
Attachment 379322: Patch
https://bugs.webkit.org/attachment.cgi?id=379322&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 379322
--> https://bugs.webkit.org/attachment.cgi?id=379322
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=379322&action=review
> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:109
> + if (frame && page) {
We should probably return ConnectStatus::KO if this is false.
More information about the webkit-reviews
mailing list