[webkit-reviews] review granted: [Bug 201633] [JSC] Remove CheckAdd in JetStream2/async-fs's Math.random function : [Attachment 379306] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 201633: [JSC] Remove CheckAdd in JetStream2/async-fs's Math.random function
https://bugs.webkit.org/show_bug.cgi?id=201633

Attachment 379306: Patch

https://bugs.webkit.org/attachment.cgi?id=379306&action=review




--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 379306
  --> https://bugs.webkit.org/attachment.cgi?id=379306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379306&action=review

Nice.  r=me

> Source/JavaScriptCore/ChangeLog:25
> +	   This converts many CheckAdd in JetStream2/async-fs's hot function
simple Add, removes bunch of unnecessary instructions which exist because of
this OSR exit.

/function simple Add, removes bunch/function to simple Add, and removes a
bunch/.

> Source/JavaScriptCore/b3/testb3_5.cpp:950
> +    CHECK(invoke<int64_t>(*code, value) == 2ll *
static_cast<int32_t>(value));

Why is this static_cast necessary?