[webkit-reviews] review granted: [Bug 201717] Web Inspector: Improve the Uncaught Exception View file a bug link : [Attachment 378632] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201717: Web Inspector: Improve the Uncaught Exception View file a bug link
https://bugs.webkit.org/show_bug.cgi?id=201717

Attachment 378632: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=378632&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378632
  --> https://bugs.webkit.org/attachment.cgi?id=378632
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378632&action=review

r=me

One thought, should we expose this (or something like this) for STP? We may
find out about more bugs that way ��

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:-283
> -	   bug with this information</a>. It is possible that someone else
broke it by accident.</dd>

lol I didn’t know it said this ��

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:301
> +	   event.stop();

Should we avoid using Utilities.js functions in this file, in case it wasn’t
loaded properly and therefore the extra functions don’t exist?

> Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp:270
> +	  
WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorP
roxy::BringInspectedPageToFront(), m_inspectedPageIdentifier);

Shouldn’t we bring to front before opening a new tab? Just thinking about it,
I’d expect the inspected page/tab/window to be focused before attempting to
open another tab.

Alternatively, should we just always bring the inspected page/tab/window to
front in the UIProcess whenever calling `openInNewTab`? Is there a situation
where we’d want to open a background tab?