[webkit-reviews] review requested: [Bug 202065] REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class : [Attachment 379298] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 20 18:06:29 PDT 2019
Nikita Vasilyev <nvasilyev at apple.com> has asked for review:
Bug 202065: REGRESSION(r243264): Web Inspector: Style pane doesn't update after
toggling CSS class
https://bugs.webkit.org/show_bug.cgi?id=202065
Attachment 379298: Patch
https://bugs.webkit.org/attachment.cgi?id=379298&action=review
--- Comment #3 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 379298
--> https://bugs.webkit.org/attachment.cgi?id=379298&action=review
Patch
This fixes the bug and clears the maps as it was before the regression was
introduced.
However, I've noticed that the existing (and pretty old) code may have race
conditions. `fetchedMatchedStyles` and` fetchedComputedStyle` are called in
parallel and they modify the same variables. I'll take a closer look.
More information about the webkit-reviews
mailing list