[webkit-reviews] review granted: [Bug 200391] Implement memory monitoring functions for Linux OS : [Attachment 377965] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Paulo Matos <pmatos at igalia.com>'s
request for review:
Bug 200391: Implement memory monitoring functions for Linux OS
https://bugs.webkit.org/show_bug.cgi?id=200391

Attachment 377965: Patch

https://bugs.webkit.org/attachment.cgi?id=377965&action=review




--- Comment #6 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 377965
  --> https://bugs.webkit.org/attachment.cgi?id=377965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377965&action=review

Besides MemoryFootprintLinux.cpp, similar functionality also exists in bmalloc.
At some point it would be nice to bring all this into a single place.

> Source/WTF/wtf/linux/ProcessMemoryFootprint.h:30
> +#if OS(LINUX)
> +#include <sys/resource.h>

Nit: this would deserve an empty line in between.

> Source/WTF/wtf/linux/ProcessMemoryFootprint.h:37
> +
> +    

Nit: and this can do with a single empty line.

> Source/WTF/wtf/linux/ProcessMemoryFootprint.h:46
> +	   return { ps.resident, static_cast<uint64_t>(ru.ru_maxrss)*1024 };

Nit: spaces around the multiplication operand.