[webkit-reviews] review canceled: [Bug 201913] [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown : [Attachment 379116] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 201913: [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown
https://bugs.webkit.org/show_bug.cgi?id=201913

Attachment 379116: Patch

https://bugs.webkit.org/attachment.cgi?id=379116&action=review




--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 379116
  --> https://bugs.webkit.org/attachment.cgi?id=379116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379116&action=review

>> Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:230
>> +	    charCode = buff[0];
> 
> Is this better than the approach taken in WebKitBrowserWindow?
>
https://github.com/WebKit/webkit/blob/master/Tools/MiniBrowser/win/WebKitBrowse
rWindow.cpp#L46-L47

Only the first character is needed. DRT also checks only the first character.

>> Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:258
>> +	keyData |= (KF_UP | KF_REPEAT) << 16;
> 
> I don't think I understand this line. Does this correspond to the PostMessage
in the DRT implementation? Why auto-repeat?

Good catch.
I removed the PostMessage(WM_CHAR) part because I couldn't
understand why it is needed and I'm too lazy to study the reason from
the commit history.

It came from Bug 11449.
https://github.com/WebKit/webkit/commit/ca3369df7ca41a2199f9d2187642989488a94e2
c

fast/forms/select-type-ahead-non-latin.html is the test case.
I need the PostMessage. Will fix.