[webkit-reviews] review canceled: [Bug 197266] UI process crash when using callOnMainThread() after the main thread dispatcher has been destroyed : [Attachment 379126] Fixes a crash when the program exists (Updated changelog, WebKit format).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 19 06:10:35 PDT 2019


Michael Catanzaro <mcatanzaro at gnome.org> has canceled  review:
Bug 197266: UI process crash when using callOnMainThread() after the main
thread dispatcher has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=197266

Attachment 379126: Fixes a crash when the program exists (Updated changelog,
WebKit format).

https://bugs.webkit.org/attachment.cgi?id=379126&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 379126
  --> https://bugs.webkit.org/attachment.cgi?id=379126
Fixes a crash when the program exists (Updated changelog, WebKit format).

View in context: https://bugs.webkit.org/attachment.cgi?id=379126&action=review

> Source/WTF/ChangeLog:3
> +	   Fix a possible crash during the program termination.

Please just make sure the first line of the ChangeLog matches the title of the
bug. I've just renamed the bug, so:

UI process crash when using callOnMainThread() after the main thread dispatcher
has been destroyed

Other than that, LGTM.

Set the r: Bugzilla flag to r? to request review. Leave r+ for the reviewer.


More information about the webkit-reviews mailing list