[webkit-reviews] review granted: [Bug 199843] [SVG2]: Add auto behavior for rx and ry to the SVG <ellipse> and <rect> elements : [Attachment 379050] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 199843: [SVG2]: Add auto behavior for rx and ry to the SVG <ellipse> and
<rect> elements
https://bugs.webkit.org/show_bug.cgi?id=199843

Attachment 379050: Patch

https://bugs.webkit.org/attachment.cgi?id=379050&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 379050
  --> https://bugs.webkit.org/attachment.cgi?id=379050
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379050&action=review

> Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:92
> +    Length rx = style().svgStyle().rx().isAuto() ? style().svgStyle().ry() :
style().svgStyle().rx();

Maybe avoid reading style().svgStyle().rx() twice. 

Length rx = style().svgStyle().rx();
if (rx.isAuto()
  rx = style().svgStyle().ry();