[webkit-reviews] review granted: [Bug 201948] Web Inspector: console assertion when pressing up/down in empty console log view : [Attachment 379088] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 18 17:25:22 PDT 2019


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201948: Web Inspector: console assertion when pressing up/down in empty
console log view
https://bugs.webkit.org/show_bug.cgi?id=201948

Attachment 379088: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=379088&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 379088
  --> https://bugs.webkit.org/attachment.cgi?id=379088
[PATCH] Proposed Fix

rs=me

Can you actually write somewhere what the assertion message/location actually
was?  I'm guessing it's the `console.assert(message)` inside
`WI.LogContentView.prototype._updateMessagesSelection`?


More information about the webkit-reviews mailing list