[webkit-reviews] review granted: [Bug 201921] NetworkLoadParameters shouldn't store sessionID : [Attachment 379057] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ben Nham <nham at apple.com>'s request
for review:
Bug 201921: NetworkLoadParameters shouldn't store sessionID
https://bugs.webkit.org/show_bug.cgi?id=201921

Attachment 379057: Patch

https://bugs.webkit.org/attachment.cgi?id=379057&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 379057
  --> https://bugs.webkit.org/attachment.cgi?id=379057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379057&action=review

r=me with nits.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:304
> +    auto* networkSession =
m_connection->networkProcess().networkSession(sessionID());

I believe this could be:
auto* networkSession = m_connection->networkSession();

> Source/WebKit/NetworkProcess/PreconnectTask.h:43
> +    explicit PreconnectTask(NetworkProcess&, PAL::SessionID,
NetworkLoadParameters&&, CompletionHandler<void(const
WebCore::ResourceError&)>&& completionHandler = { });

nit: we should probably drop the explicit.