[webkit-reviews] review granted: [Bug 201713] ASSERT NOT REACHED in Inspector::InjectedScriptModule::ensureInjected() seen with inspector/heap/getRemoteObject.html : [Attachment 379019] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 201713: ASSERT NOT REACHED in
Inspector::InjectedScriptModule::ensureInjected() seen with
inspector/heap/getRemoteObject.html
https://bugs.webkit.org/show_bug.cgi?id=201713

Attachment 379019: Patch

https://bugs.webkit.org/attachment.cgi?id=379019&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 379019
  --> https://bugs.webkit.org/attachment.cgi?id=379019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379019&action=review

r=me

> Source/JavaScriptCore/inspector/InjectedScriptModule.cpp:75
> +	   WTFLogAlways("Error when calling 'hasInjectedModule' for '%s': %s
(%d:%d)\n", name().ascii().data(),
hasInjectedModuleResult.error().value().toWTFString(injectedScript.scriptState(
)).ascii().data(), line, column);

Why do we use `ascii().data()` instead of `utf8().data()`? That would at least
have newlines.

> Source/JavaScriptCore/runtime/Exception.h:63
> +    JS_EXPORT_PRIVATE ~Exception();

Weird. Was this needed?