[webkit-reviews] review granted: [Bug 201870] [GStreamer] isAVC1CodecSupported is crashing several media source tests due to avc1.4d4001 codec type : [Attachment 378962] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 18 02:44:13 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 201870: [GStreamer] isAVC1CodecSupported is crashing several media source
tests due to avc1.4d4001 codec type
https://bugs.webkit.org/show_bug.cgi?id=201870

Attachment 378962: Patch

https://bugs.webkit.org/attachment.cgi?id=378962&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 378962
  --> https://bugs.webkit.org/attachment.cgi?id=378962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378962&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:322
> +    char levelAsStringFallback[2] = { '\0', '\0' };

This is a bit too tricky so I would recommend adding a with this bug number to
enable a very quick access to the info.


More information about the webkit-reviews mailing list