[webkit-reviews] review granted: [Bug 201799] Change WebAssembly calling conventions : [Attachment 378986] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted  review:
Bug 201799: Change WebAssembly calling conventions
https://bugs.webkit.org/show_bug.cgi?id=201799

Attachment 378986: Patch

https://bugs.webkit.org/attachment.cgi?id=378986&action=review




--- Comment #18 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 378986
  --> https://bugs.webkit.org/attachment.cgi?id=378986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378986&action=review

r=me

>> Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:123
>> +		targetCallee.addAndLinkCaller(holder, linkBuffer,
call.unlinkedMoveAndCall);
> 
> this targetCallee is different than the one below. The below is what we're
compiling. This targetCallee is what OMG is going to call. It seems wrong to
make OMG compile always call BBQ...

I see. addAndLinkCaller looks for a replacement. Seems like kinda a weird
paradigm, but it's OK