[webkit-reviews] review granted: [Bug 201728] IndexedDB: add size estimate for keypath and other key types : [Attachment 378975] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 17 13:37:07 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 201728: IndexedDB: add size estimate for keypath and other key types
https://bugs.webkit.org/show_bug.cgi?id=201728

Attachment 378975: Patch

https://bugs.webkit.org/attachment.cgi?id=378975&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 378975
  --> https://bugs.webkit.org/attachment.cgi?id=378975
Patch

r=me

Are we going to serialize the key again when we store it? If so, it might be
nice for our caller to compute the serialized key once, and then pass it to all
callees who will need it.


More information about the webkit-reviews mailing list