[webkit-reviews] review denied: [Bug 201824] [MSE][GStreamer] Allow MSE on builds with gst>=1.14 : [Attachment 378866] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied  review:
Bug 201824: [MSE][GStreamer] Allow MSE on builds with gst>=1.14
https://bugs.webkit.org/show_bug.cgi?id=201824

Attachment 378866: Patch

https://bugs.webkit.org/attachment.cgi?id=378866&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 378866
  --> https://bugs.webkit.org/attachment.cgi?id=378866
Patch

This will break distros. You can't expect distros to know that a special patch
has to be applied. You should require the three-digit version number that's
needed for this to work. E.g. require 1.14.6. Sadly, GStreamer developers say
1.14 is dead and there will be no 1.14.6, so can't do that.

I guess stable distros will just have to disable MSE. :/ This is not only
important for LTS distros. Fedora 29 is still supported for another two months,
and it will have to disable MSE to update to 2.26.