[webkit-reviews] review granted: [Bug 201757] Web Inspector: HTML Formatter - better handling for HTML specific tag cases (<p>/<li>) : [Attachment 378877] [PATCH] Proposed Fix

Mon Sep 16 21:36:07 PDT 2019

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201757: Web Inspector: HTML Formatter - better handling for HTML specific
tag cases (<p>/<li>)
https://bugs.webkit.org/show_bug.cgi?id=201757

Attachment 378877: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=378877&action=review

--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378877
  --> https://bugs.webkit.org/attachment.cgi?id=378877
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378877&action=review

r=me, nice work!

>
LayoutTests/inspector/formatting/resources/html-tests/auto-close-special.html:2
> +<head><title>Title</title>

Can we omit the `</title>` to ensure that the `<body>` still closes the
`<head>` even if there are other open tags "in between"?

>
Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLTreeBuilderFormatter.
js:241
> +	   console.assert(!this._isXML, "Implicitly closing only happens in
HTML. Also, names are compared case insensitively which would be invalid for
XML");

NIT: missing "." at the end :(