[webkit-reviews] review granted: [Bug 201853] CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage : [Attachment 378924] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 201853: CheckArray on DirectArguments/ScopedArguments does not filter out
slow put array storage
https://bugs.webkit.org/show_bug.cgi?id=201853

Attachment 378924: patch

https://bugs.webkit.org/attachment.cgi?id=378924&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 378924
  --> https://bugs.webkit.org/attachment.cgi?id=378924
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378924&action=review

r=me with comment.

> Source/JavaScriptCore/dfg/DFGArrayMode.h:447
> +	       return arrayModesWithIndexingShapes(ArrayStorageShape, NonArray)
| arrayModesWithIndexingShapes(SlowPutArrayStorageShape, NonArray);

Should we just do like, `arrayModesWithIndexingShapes(NonArray,
ArrayStorageShape, SlowPutArrayStorageShape)`?