[webkit-reviews] review granted: [Bug 198176] [WebAuthn] Use WebPreferences instead of RuntimeEnabledFeatures in UIProcess : [Attachment 378914] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 17:08:44 PDT 2019
youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 198176: [WebAuthn] Use WebPreferences instead of RuntimeEnabledFeatures in
UIProcess
https://bugs.webkit.org/show_bug.cgi?id=198176
Attachment 378914: Patch
https://bugs.webkit.org/attachment.cgi?id=378914&action=review
--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378914
--> https://bugs.webkit.org/attachment.cgi?id=378914
Patch
OK, let's go.
I would continue to reduce the use of WTF::get.
Methods like continueGetAssertionAfterUserConsented could be given the
correctly typed values so that only makeCredential/getAssertion and their
lambdas would do the WTF::get
More information about the webkit-reviews
mailing list