[webkit-reviews] review granted: [Bug 201734] results.webkit.org: Shard result archives : [Attachment 378905] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 201734: results.webkit.org: Shard result archives
https://bugs.webkit.org/show_bug.cgi?id=201734

Attachment 378905: Patch

https://bugs.webkit.org/attachment.cgi?id=378905&action=review




--- Comment #16 from dewei_zhu at apple.com ---
Comment on attachment 378905
  --> https://bugs.webkit.org/attachment.cgi?id=378905
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378905&action=review

> Tools/resultsdbpy/resultsdbpy/model/archive_context.py:181
> +		       if not value.get('digest'):
> +			   raise RuntimeError('Archive metadata does not
contain a hash')

We can also move this to above for loop so that we fail early with lightweight.