[webkit-reviews] review granted: [Bug 201829] SamplingProfiler should hold API lock before reporting results : [Attachment 378882] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 201829: SamplingProfiler should hold API lock before reporting results
https://bugs.webkit.org/show_bug.cgi?id=201829

Attachment 378882: Patch

https://bugs.webkit.org/attachment.cgi?id=378882&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 378882
  --> https://bugs.webkit.org/attachment.cgi?id=378882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378882&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1029
> +	   JSLockHolder holder(m_vm);

Can you ensure that this locking order (registerationLock -> APILock) is
correct? (maybe, in practice, it does not matter).