[webkit-reviews] review granted: [Bug 201808] Update testharness.js from upstream : [Attachment 378833] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 12:54:32 PDT 2019
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 201808: Update testharness.js from upstream
https://bugs.webkit.org/show_bug.cgi?id=201808
Attachment 378833: Patch
https://bugs.webkit.org/attachment.cgi?id=378833&action=review
--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 378833
--> https://bugs.webkit.org/attachment.cgi?id=378833
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=378833&action=review
Mostly just a rubber stamp of the idea of doing this, but a couple comments.
> LayoutTests/fast/events/clipboard-event-constructor.html:64
> +}, "bubbles / cancelabble / composed members");
Typo here, only one "b" in "cancelable".
> LayoutTests/fast/mediastream/captureStream/canvas2d-expected.txt:4
> -PASS captureStream cloning
> +FAIL captureStream cloning assert_array_equals: property 5, expected 127 but
got 128
Do we have to change this, since we are putting a test expectation in for this
test?
More information about the webkit-reviews
mailing list