[webkit-reviews] review canceled: [Bug 201814] Fix leaks in DumpRenderTree and WebKitTestRunner : [Attachment 378846] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 16 05:20:38 PDT 2019


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 201814: Fix leaks in DumpRenderTree and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=201814

Attachment 378846: Patch v2

https://bugs.webkit.org/attachment.cgi?id=378846&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 378846
  --> https://bugs.webkit.org/attachment.cgi?id=378846
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=378846&action=review

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:124
>> +	self.rotationDidEndCallback = nil;
> 
> These should be taken care of by -resetInteractionCallbacks, no?

Oops!  You are correct.  Will remove.


More information about the webkit-reviews mailing list