[webkit-reviews] review granted: [Bug 201804] [JSC] REGRESSION (r248938): Leak of uint32_t arrays in testFastForwardCopy32() : [Attachment 378812] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 15 22:02:28 PDT 2019


Saam Barati <sbarati at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 201804: [JSC] REGRESSION (r248938): Leak of uint32_t arrays in
testFastForwardCopy32()
https://bugs.webkit.org/show_bug.cgi?id=201804

Attachment 378812: Patch v2

https://bugs.webkit.org/attachment.cgi?id=378812&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 378812
  --> https://bugs.webkit.org/attachment.cgi?id=378812
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=378812&action=review

> Source/JavaScriptCore/b3/testb3_8.cpp:885
> +		       array1 = std::make_unique<uint32_t[]>(arrsize);

Should we be using WTF::makeUnique?


More information about the webkit-reviews mailing list