[webkit-reviews] review requested: [Bug 201240] [WHLSL] Add an analysis to verify that functions like control barriers and derivatives are not called in non-uniform control flow. : [Attachment 378768] Patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has asked	for review:
Bug 201240: [WHLSL] Add an analysis to verify that functions like control
barriers and derivatives are not called in non-uniform control flow.
https://bugs.webkit.org/show_bug.cgi?id=201240

Attachment 378768: Patch

https://bugs.webkit.org/attachment.cgi?id=378768&action=review




--- Comment #23 from Robin Morisset <rmorisset at apple.com> ---
Created attachment 378768

  --> https://bugs.webkit.org/attachment.cgi?id=378768&action=review

Patch

Implemented Saam's suggestion + the analysis now supports comma on the
left-side of assignment.
I don't believe it is a good idea to have them, but
https://bugs.webkit.org/show_bug.cgi?id=201251 introduced them, and dealing
with them is much easier than finding how to avoid generating them in that
other pass.