[webkit-reviews] review granted: [Bug 201371] Provide a prototype for AR QuickLook to trigger processing in the originating page : [Attachment 378606] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 201371: Provide a prototype for AR QuickLook to trigger processing in the
originating page
https://bugs.webkit.org/show_bug.cgi?id=201371

Attachment 378606: Patch

https://bugs.webkit.org/attachment.cgi?id=378606&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 378606
  --> https://bugs.webkit.org/attachment.cgi?id=378606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378606&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:489
> +	   systemPreviewInfo.globalFrameID.frameID =
document().frame()->loader().client().frameID().valueOr(FrameIdentifier { });
> +	   systemPreviewInfo.globalFrameID.pageID =
document().frame()->loader().client().pageID().valueOr(PageIdentifier { });

Weird flex but OK. Not sure why the PageIdentifier and FrameIdentifiers aren't
on Page and Frame. Chris?

> Source/WebCore/loader/FrameLoaderTypes.h:185
> +    IntRect previewRect;

What coordinate system is this rect in?

> Source/WebKit/UIProcess/SystemPreviewController.h:65
> +    void triggerSystemPreviewActionWithTarget(uint64_t frameID, uint64_t
pageID);

Maybe put "ForTesting" in the name