[webkit-reviews] review granted: [Bug 201746] AuxiliaryProcessProxy::sendWithAsyncReply should queue up messages if sent while the process is starting like it does messages without replies : [Attachment 378716] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 201746: AuxiliaryProcessProxy::sendWithAsyncReply should queue up messages
if sent while the process is starting like it does messages without replies
https://bugs.webkit.org/show_bug.cgi?id=201746

Attachment 378716: Patch

https://bugs.webkit.org/attachment.cgi?id=378716&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378716
  --> https://bugs.webkit.org/attachment.cgi?id=378716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378716&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:213
> +	   OptionSet<IPC::SendOption> sendOptions = pendingMessage.sendOptions;

both can be auto.

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:230
>	   m_connection->sendMessage(WTFMove(message), sendOptions);

I guess sendMessage can only return true here.
I would assert it though. In theory, we could add the async reply handler that
would only complete once the connection is destroyed.