[webkit-reviews] review granted: [Bug 201698] Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload : [Attachment 378662] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201698: Web Inspector: [Overrides] Command-Z doesn't undo changes after
page reload
https://bugs.webkit.org/show_bug.cgi?id=201698

Attachment 378662: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=378662&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378662
  --> https://bugs.webkit.org/attachment.cgi?id=378662
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378662&action=review

r=me, it doesn't look like `WI.TextResourceContentView` (or any of it's
superclasses) rely on the current main frame, so I think this is safe :)

> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:289
> +	   for (let i = 0; i < this._backForwardList.length; ++i) {

`for (let entry of this._backForwardList)`