[webkit-reviews] review granted: [Bug 201729] Uncaught Exception: null is not an object (evaluating 'Object.keys(propertyNames)') (at JavaScriptRuntimeCompletionProvider.js:244:57) : [Attachment 378667] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 12 15:26:18 PDT 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201729: Uncaught Exception: null is not an object (evaluating
'Object.keys(propertyNames)') (at
JavaScriptRuntimeCompletionProvider.js:244:57)
https://bugs.webkit.org/show_bug.cgi?id=201729
Attachment 378667: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=378667&action=review
--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378667
--> https://bugs.webkit.org/attachment.cgi?id=378667
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=378667&action=review
r=me, nice! I've encountered this a handful of times but could never
reproduce. Great catch! =D
>
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProv
ider.js:378
> + this._ongoingCompletionRequests++;
Style: `++this._ongoingCompletionRequests;`
>
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProv
ider.js:381
> + _decrementOngoingCompletionRequests()
Style: `--this._ongoingCompletionRequests;`
>
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProv
ider.js:385
> + if (!this._ongoingCompletionRequests)
We should assert that we haven't gone below `0` (and maybe even change the `if`
condition to reflect that as well, given how many different branches this code
has).
More information about the webkit-reviews
mailing list