[webkit-reviews] review granted: [Bug 201697] Re-sync dom web-platform-tests from upstream : [Attachment 378583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 01:32:28 PDT 2019


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 201697: Re-sync dom web-platform-tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=201697

Attachment 378583: Patch

https://bugs.webkit.org/attachment.cgi?id=378583&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378583
  --> https://bugs.webkit.org/attachment.cgi?id=378583
Patch

Some tests need iOS wk2 expected.txt file updates.

View in context: https://bugs.webkit.org/attachment.cgi?id=378583&action=review

> LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.html:1
> +<!-- This file is required for WebKit test infrastructure to run the
templated test -->

Let's remove that file or skip the test given the above error message.

> LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.js:1
> +// META: global=!window,worker

I'll try to check whether we are expected to look at the META tag instead of
.any.js to create window/worker html dummy files by w3c importer.
Or maybe it should be moved to ildharness.worker.js


More information about the webkit-reviews mailing list