[webkit-reviews] review granted: [Bug 200637] Web Inspector: REGRESSION: Inspector Timeline always starts at about 500ms mark on a reload : [Attachment 378620] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 11 23:18:17 PDT 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200637: Web Inspector: REGRESSION: Inspector Timeline always starts at
about 500ms mark on a reload
https://bugs.webkit.org/show_bug.cgi?id=200637
Attachment 378620: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=378620&action=review
--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378620
--> https://bugs.webkit.org/attachment.cgi?id=378620
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=378620&action=review
r=me, thanks for iterating :)
> Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js:108
> + get unadjustedStartTime()
We should move this to be next to `get activeStartTime`.
> Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js:114
> + get unadjustedEndTime()
We should move this to be right after `get endTime`.
More information about the webkit-reviews
mailing list