[webkit-reviews] review granted: [Bug 201459] Use WebProcess processIdentifier to identify Service Worker connections : [Attachment 378359] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 11 08:50:59 PDT 2019


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201459: Use WebProcess processIdentifier to identify Service Worker
connections
https://bugs.webkit.org/show_bug.cgi?id=201459

Attachment 378359: Patch

https://bugs.webkit.org/attachment.cgi?id=378359&action=review




--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 378359
  --> https://bugs.webkit.org/attachment.cgi?id=378359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378359&action=review

r=me, let's split the sessions in a follow-up.

> Source/WebCore/workers/service/ServiceWorkerTypes.h:75
>  using SWServerConnectionIdentifier =
ObjectIdentifier<SWServerConnectionIdentifierType>;

Why isn't this simply using SWServerConnectionIdentifier = ProcessIdentifier; ?

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:298
> +		   sessionID = server.sessionID();

Seems unfortunate we'll keep iterating even though we've found the sessionID.

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:893
> +    m_swContextConnection =
WebSWServerToContextConnection::create(m_networkProcess, registrableDomain,
m_connection.get());

WTFMove(registrableDomain) ?

> Source/WebKit/UIProcess/WebProcessPool.cpp:699
> +    WebsiteDataStore* websiteDataStore =
WebsiteDataStore::existingNonDefaultDataStoreForSessionID(sessionID);

auto*


More information about the webkit-reviews mailing list