[webkit-reviews] review granted: [Bug 201655] Remove unnecessary abstractions around WebsiteDataStore : [Attachment 378554] Updated patch with GLib API fixes

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 201655: Remove unnecessary abstractions around WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=201655

Attachment 378554: Updated patch with GLib API fixes

https://bugs.webkit.org/attachment.cgi?id=378554&action=review




--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 378554
  --> https://bugs.webkit.org/attachment.cgi?id=378554
Updated patch with GLib API fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=378554&action=review

r=me

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:106
> +    explicit WebsiteDataStore(Ref<WebsiteDataStoreConfiguration>&&,
PAL::SessionID);

explicit is not needed.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:305
> +    enum ShouldCreateDirectory { CreateDirectory, DontCreateDirectory };

Could you please use an enum class ? E.g. enum class ShouldCreateDirectory {
No, Yes };