[webkit-reviews] review granted: [Bug 201670] Web Inspector: Canvas: checkerboard has too much contrast in dark mode : [Attachment 378525] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 201670: Web Inspector: Canvas: checkerboard has too much contrast in dark
mode
https://bugs.webkit.org/show_bug.cgi?id=201670

Attachment 378525: Patch

https://bugs.webkit.org/attachment.cgi?id=378525&action=review




--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 378525
  --> https://bugs.webkit.org/attachment.cgi?id=378525
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378525&action=review

> Source/WebInspectorUI/ChangeLog:10
> +	   Don't force a `background-color: white;` in dark mode.

I think the right fix for this might be to keep forcing white and correct the
checker color to be light, like in light mode. Most of the transparent content
will be light mode content and might not look good over a dark mode
checkerboard. We might need a dark mode toggle for the checkerboard.