[webkit-reviews] review granted: [Bug 201663] SVGLengthValue should use two enums for 'type' and 'mode' instead of one unsigned for 'units' : [Attachment 378508] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 201663: SVGLengthValue should use two enums for 'type' and 'mode' instead
of one unsigned for 'units'
https://bugs.webkit.org/show_bug.cgi?id=201663

Attachment 378508: Patch

https://bugs.webkit.org/attachment.cgi?id=378508&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 378508
  --> https://bugs.webkit.org/attachment.cgi?id=378508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378508&action=review

> Source/WebCore/svg/SVGLengthValue.cpp:328
> +    if (from.lengthType() == lengthType() || from.isZero() || isZero() ||
from.lengthType() == SVGLengthType::EMS || from.lengthType() ==
SVGLengthType::EXS) {

This is pretty confusing.

> Source/WebCore/svg/SVGLengthValue.h:87
> +    void newValueSpecifiedUnits(SVGLengthType, float valueInSpecifiedUnits);

What does "new value" mean here?